Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS injection in column names #794

Closed
benrr101 opened this issue Mar 27, 2017 · 1 comment
Closed

JS injection in column names #794

benrr101 opened this issue Mar 27, 2017 · 1 comment
Assignees
Labels

Comments

@benrr101
Copy link
Contributor

Using a column defined as [<script type='text/javascript'>alert('qqq')</script>], the column header when selecting * for the table will be blank. This implies that the column header is being interpreted as javascript, thus this is a javascript injection bug.

Fortunately, there's not a large impact for this bug since 1) column names that are js script tags are highly unlikely, and likely only going to cause a js injection on yourself, and 2) the webview prevents requests to outside its origin (ie, localhost).

Nevertheless this is a issue that should be fixed like we fixed it in the cells.

@benrr101
Copy link
Contributor Author

Fixed in #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant