Build tags breaks go to definition and other features

[inancgumus]

When I add a build tag on top of a file, vscode-go go to definition and mouse over peak functionality breaks.

When I remove it, it works again.

// +build integration

See this:

[ramya-rao-a]

@inancgumus Do you have the language server turned on?

[inancgumus]

Do you mean this? If so, I'll try it.

What do you think about why this happens when I add a build tag? Even because of the lang-server. Because, it works w/out build tags.

[ramya-rao-a]

We have 3 different ways of providing the definition information

• go.docsTool is set to godoc (default)
• go.docsTool is set to gogetdoc
• go.useLanguageServeris set totrue`

I was trying to see which one of the above categories does your scenario fall into.

I can repro this issue in the second and third case but not the first.

cc @zmb3 for gogetdoc and @slimsag for the language server

[zmb3]

This makes a lot of sense. Feel free to file an issue at github.com/zmb3/gogetdoc for build tag support and I will look to add a way to provide build tags to the tool.

I can repro this issue in the second and third case but not the first.

In the first case, how are you actually getting definition information? I wasn't aware that godoc spits that out.

[ramya-rao-a]

@zmb3 its godef that gives the definition info

When I added the setting to choose between default implementation (godef + godoc) and gogetdoc, I couldnt come up with a better name than go.docsTool and since it says "docstool", the options were godoc and gogetdoc :)

[ramya-rao-a]

Logged an issue for gogetdoc and the language server and closing this issue

[ramya-rao-a]

Re-opening to absorb the changes done in gogetdoc

[inancgumus]

@ramya-rao-a I couldn't see the absorbed changes from gogetdoc?

[ramya-rao-a]

I am yet to release an update (should be out in the next few days).
You will see the changes then.

[ramya-rao-a]

go.buildTags will now be honored when using the Go to definition feature in the latest update (0.6.63) to the Go extension

[inancgumus]

@ramya-rao-a That's perfect, thanks!