(GH-96) Add auto refresh with configuration to enable it and set refresh interval #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set refresh interval
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Time interval in seconds for treeview auto refresh, auto refresh has to be enabled for it to work. (default is `60`): |
src/deviceTree.ts
Outdated
| if (treeViewAutoRefreshEnable) { | ||
| let treeViewAutoRefreshIntervalInSeconds = Utility.getConfig<number>(Constants.TreeViewAutoRefreshIntervalInSecondsKey); | ||
| setInterval(() => { | ||
| vscode.commands.executeCommand("azure-iot-toolkit.refresh"); |
There was a problem hiding this comment.
Here could just use this._onDidChangeTreeData.fire();
src/deviceTree.ts
Outdated
| @@ -12,6 +12,13 @@ export class DeviceTree implements vscode.TreeDataProvider<vscode.TreeItem> { | |||
| public readonly onDidChangeTreeData: vscode.Event<vscode.TreeItem | undefined> = this._onDidChangeTreeData.event; | |||
|
|
|||
| constructor(private context: vscode.ExtensionContext) { | |||
| let treeViewAutoRefreshEnable = Utility.getConfig<boolean>(Constants.TreeViewAutoRefreshEnableKey); | |||
| if (treeViewAutoRefreshEnable) { | |||
There was a problem hiding this comment.
Think about the scenario: The interval is set as 5 seconds, while the tree view takes 8 seconds to render.
Same with your concern, would better to put this logic into getChildren(), setInterval after tree view is rendered,
If the logic is in getChildren(), we also need to clearTimeout for previous setInterval.
formulahendry
suggested changes
Oct 18, 2018
|
Thank you for your feedback, I applied all the comments, hopefully it's good now. |
|
Awesome! Thanks @tomaszbartoszewski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are few things, I'm not sure about. The name for settings is one thing. I set default interval to 60 seconds, as I thought it's better than too low value, in case somebody enables it by accident, but maybe it should be higher. The biggest concern I have is about
setIntervalinside constructor and reading config there, if there is a better way of doing it, I'm happy to improve my code.