Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

ReactThisBindingIssueRule should use Sets on the inside #535

Closed
JoshuaKGoldberg opened this issue Oct 9, 2018 · 1 comment
Closed

ReactThisBindingIssueRule should use Sets on the inside #535

JoshuaKGoldberg opened this issue Oct 9, 2018 · 1 comment
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs
Milestone
6.0.0-beta

Comments

@JoshuaKGoldberg
Copy link

https://node.green/#ES2015-built-ins-Set

Sets have been supported in Node for quite some time. It'd be a bit more clear and efficient on super long files to use them instead of arrays for the internal members.

Not a huge priority (functionality shouldn't change), and should come after #534 is merged.
@JoshuaKGoldberg JoshuaKGoldberg added Status: Accepting PRs Good First Issue 🙌 Howdy, neighbor! Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Hacktoberfest labels Oct 9, 2018
@cyberhck
Copy link
Contributor

cyberhck commented Oct 10, 2018 •
edited
Loading

Do you mean for private properties? Where we store the data?
Is that supposed to contain everything? If so, how about the data types? Will there be no types? Or we create separate sets for separate type of data? I want to take a stab on this issue after that's merged 🙂

And is it only for reactThisBindingIssue? or everywhere?

jonascarlsonschmidt added a commit to jonascarlsonschmidt/tslint-microsoft-contrib that referenced this issue Oct 12, 2018
@jonascarlsonschmidt
microsoft#535 In ReactThisBindingIssueRule internal arrays are replac…
1d2862a 
…ed by sets
@jonascarlsonschmidt jonascarlsonschmidt mentioned this issue Oct 12, 2018
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Oct 15, 2018
@jonascarlsonschmidt
#535 In ReactThisBindingIssueRule internal arrays are replaced by sets (
875f2f2 
#544)

🙌
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Difficulty: Easy Someone with little to no experience in TSLint should be able to send a pull request for this issue. Good First Issue 🙌 Howdy, neighbor! Status: Accepting PRs
Projects
None yet
Milestone
6.0.0-beta
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @cyberhck