This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Replace "/.*\.tsx/.test(...)" in source code with String.endsWith(".tsx") #525
Labels
Difficulty: Easy
Someone with little to no experience in TSLint should be able to send a pull request for this issue.
Good First Issue 🙌
Howdy, neighbor!
Status: Accepting PRs
Type: Bug
Milestone
Comments
JoshuaKGoldberg
added
Type: Bug
Status: Accepting PRs
Good First Issue 🙌
|
I'm on it |
roblourens
added a commit
to roblourens/tslint-microsoft-contrib
that referenced
this issue
Oct 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See discussion in #521.
/.*\.tsx/.test(node.fileName)will accidentally skip non-tsx files in the rare case of someone including .tsx in their file name before the extension, such as the very oddfoo.tsx.ts. Let's switch it to just checking if the string ends with the .tsx extension.endsWithis supported in all Node versions we support here.The text was updated successfully, but these errors were encountered: