Option request: allow same folder imports (no-relative-import)

[axelboc]

Angular generates specs with same folder imports, like:

import { MyComponent } from './my.component';

So it would be really convenient if rule no-relative-import had an option to ignore imports that point to the same folder as the current file, with ./.

With this option enabled, the no-relative-import rule would still have to report unnecessarily complex same folder imports like ./../my/my.component.

[IllusionMH]

May I take on this?

If I understand correctly - new option should be created.
Is there any preference for option name?
Candidates:

• allowSameFolder
• allowSameFolderImport
• allowSiblings

[JoshuaKGoldberg]

Absolutely @IllusionMH, thanks for taking this on!

I like allowSiblings allow-siblings the most personally.

Edit: yes, what karol-majewski commented!

[karol-majewski]

allow-siblings or allow-same-folder perhaps? This would match the kebab-case convention used for other rules.

"only-arrow-functions": [true, "allow-declarations", "allow-named-functions"]

[IllusionMH]

@karol-majewski thanks for suggestions. I will use kebab-case.

@JoshuaKGoldberg I will implement with allow-siblings first, and it will be possible to decide on final name in PR.

[IllusionMH]

Sorry for pinging all in this thread, but in the process of implementation I had another question:

Should rule allow

import { MyComponent } from './subcomponents/sub.component';

when allow-siblings is enabled?

Or it might be another option to the rule?

P.S. Its really late here, so I'll hope to submit first WIP PR tomorrow.

[JoshuaKGoldberg]

That seems reasonable to allow by default, especially for projects that store assets inline with components:

import { closeIcon } from "./my.component/assets";