Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

#391 Upgrade grunt and other library versions in build #391

Merged
merged 1 commit into from
Sep 4, 2017
Merged

#391 Upgrade grunt and other library versions in build #391

merged 1 commit into from
Sep 4, 2017

Conversation

dawsbot
Copy link
Contributor

@dawsbot dawsbot commented Sep 3, 2017

  • Previous version of grunt fails on raw npm install && npm test if you don't have grunt installed globally.

This makes it possible for a fresh contributor (like me!) to get downloaded and passing tests instantly

@msftclas
Copy link

msftclas commented Sep 3, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

{ "name": "Bernd Kiefer", "email": "[email protected]" },
{ "name": "Daniel Manesku", "email": "[email protected]" },
{ "name": "Hamlet D'Arcy", "email": "[email protected]" }
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-formatted by npm 5 (I did not include the lockfile in this PR since y'all don't use npm 5 on this project)

@HamletDRC HamletDRC changed the title Upgrade grunt #391 Upgrade grunt and other library versions in build Sep 4, 2017
@HamletDRC HamletDRC added this to the 5.0.2 milestone Sep 4, 2017
@HamletDRC HamletDRC merged commit 42e11d6 into microsoft:master Sep 4, 2017
@HamletDRC
Copy link
Member

thanks, I appreciate you taking the time to do this.

@dawsbot dawsbot deleted the upgrade-grunt branch September 5, 2017 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants