You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
The grunt task for compiling the TypeScript source and the tsconfig.json in this repo do not match; clearly the config defined for grunt is the one being used in CI builds. I'd propose we keep configurations inside tsconfig.json where most people expect to find the compiler options, and let the grunt task use this file. That way, compilation is consistent regardless of whether using grunt of tsc directly. The tsconfig.json also is how VS Code finds the options to use and I'm not sure it can integrate with grunt in that way.
Sounds good to me, I think making tsconfig the single source of Truth is
the best way to go. To be honest, I don't use VS Code, so I just accepted
that file as IDE config in a pull request.
On Apr 7, 2017 08:19, "Brian Golden" ***@***.***> wrote:
The grunt task for compiling the TypeScript source and the tsconfig.json
in this repo do not match; clearly the config defined for grunt is the one
being used in CI builds. I'd propose we keep configurations inside
tsconfig.json where most people expect to find the compiler options, and
let the grunt task use this file. That way, compilation is consistent
regardless of whether using grunt of tsc directly. The tsconfig.json also
is how VS Code finds the options to use and I'm not sure it can integrate
with grunt in that way.
@HamletDRC <https://github.com/HamletDRC> what would you prefer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#360>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AALYIRYjNVuyKwNtN1htQrggpws3Ov-Aks5rtdVpgaJpZM4M2gCO>
.
The grunt task for compiling the TypeScript source and the tsconfig.json in this repo do not match; clearly the config defined for grunt is the one being used in CI builds. I'd propose we keep configurations inside tsconfig.json where most people expect to find the compiler options, and let the grunt task use this file. That way, compilation is consistent regardless of whether using grunt of tsc directly. The tsconfig.json also is how VS Code finds the options to use and I'm not sure it can integrate with grunt in that way.
@HamletDRC what would you prefer?
The text was updated successfully, but these errors were encountered: