Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Support for Typescript 2.1 #312

Closed
wants to merge 17 commits into from
Closed

Support for Typescript 2.1 #312

wants to merge 17 commits into from

Conversation

zemlanin
Copy link
Contributor

There were a few breaking changes in TS 2.1 in typings (NodeFlags split into NodeFlags and ModifierFlags, ScriptTarget.ES6 renamed to ScriptTarget.ES2016, some changes in JSX definitions)

Plus, the compiler still has bug (?) regarding callback referencing this inside and passed to super()

This PR, hopefully, fixes all of them

@msftclas
Copy link

Hi @zemlanin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@zemlanin
Copy link
Contributor Author

Signed CLA

@HamletDRC HamletDRC added this to the 2.0.14 milestone Nov 20, 2016
@HamletDRC HamletDRC closed this in 67b2752 Nov 20, 2016
@HamletDRC
Copy link
Member

Great work, thank you very much.

This is available on our "releases" branch now. You can point your npm dependency there if you need the latest files.

@zemlanin
Copy link
Contributor Author

@HamletDRC Glad to help. After this changes, tslint-microsoft-contrib requires TS2.1:

...
### Fast Compile >>./src/utils/implicitRoles/tr.ts
### Fast Compile >>./src/utils/implicitRoles/ul.ts
### Fast Compile >>./src/validTypeofRule.ts
Using tsc v2.0.10
src/utils/AstUtils.ts(110,22): error TS2339: Property 'getCombinedModifierFlags' does not exist on type 'typeof ts'.
src/utils/AstUtils.ts(110,58): error TS2339: Property 'ModifierFlags' does not exist on type 'typeof ts'.
...

So I'm not sure about 2.0.14 milestone :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants