Skip to content

Conversation

@singhsarab
Copy link
Contributor

@singhsarab singhsarab commented Apr 17, 2018

Making test timeout configurable via runsettings
microsoft/testfx-docs#40

@singhsarab singhsarab requested a review from jayaranigarg April 17, 2018 11:06
string runSettingxml =
@"<RunSettings>
<MSTestV2>
<TestTimeout>4000</TestTimeout>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add one negative test case where timeout is invalid(negative value or non-integer value)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


return timeoutAttribute.Timeout;
}
else if (globalTimeout > 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we asked @pvlakshm about precedence order?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when we passing runsettings arguments through commandline??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants