-
Notifications
You must be signed in to change notification settings - Fork 103
Implemented Dataset Autosave #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sources/Tools/PsiStudio/Microsoft.Psi.PsiStudio/PsiStudioSettings.cs
Outdated
Show resolved
Hide resolved
Sources/Visualization/Microsoft.Psi.Visualization.Windows/ViewModels/DatasetViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks a lot for this PR! I made a few comments, most of them stylistical in nature, let me know what you think.
Thanks Dan! I just made all the suggested changes. I added the events Besides that, I also propagated the change of |
Sources/Tools/PsiStudio/Microsoft.Psi.PsiStudio/MainWindow.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes! I suggested a couple of small additional changes. It would be great to call the events a minimum number of times, at the very bottom of the API stack and have the higher level API calls not duplicate the event handler call.
I just made the suggested changes. It should be ready to go! I did found a few more places where the
Both |
Sources/Visualization/Microsoft.Psi.Visualization.Windows/ViewModels/DatasetViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiangzhi!
Implementation of the feature discussed in #157
The main changes are as follows:
Dataset.cs
know takes in an optional save path and autosave variable. If true, any dataset structural changes are automatically saved upon the completion. This also applies to Sessions where if new derived partitions are created, the dataset is saved as well.AutoSaveDataset
that when set to true, all dataset created/loadeed will be in autosave mode IF a save path is known.I also created a property called
UnsavedChanges
that is toggled if autosave is disabled. This would let us check if any changes has been done since the last save. I haven't figure out how to hook it up with the name in PsiStudio.Any feedback and suggestion on better implementation is welcome!