-
Notifications
You must be signed in to change notification settings - Fork 28
Provide diagnostic option to enable on-demand schema loading #7
Conversation
- make sure that on-demand loading of schemas works as in VSCode - bump version of plugin
Hi, @aeschli |
Oh, I see, |
Hi, @aeschli |
@@ -30,6 +30,10 @@ declare module monaco.languages.json { | |||
*/ | |||
readonly schema?: any; | |||
}[]; | |||
/** | |||
* If set, the schema service would load schema content on-demand with 'fetch' if available, otherwise content would be taken from `schemas` property | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the code will always check the schemas provided through the schemas
property first, and if nothing found, will use the requestService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @aeschli
I've removed part about existing functionality
bump version
Hi, All |
Gentle ping for @aeschli |
@nesterone Can you remove the version change from package.json? We will do that when releasing the next editor version. |
Thanks @kuzya-zz ! |
I've met a problem that the schema resource needs credentials, can I set a custom
|
VSCode supports on-demand loading of url content for
$schema
, it's a part ofMicrosoft/vscode-json-languageservice
, however, it's not available through monaco-editorSuch functionality would be a good plus, for example it was requested in vega/editor/issues/33 and I see similar feature request here microsoft/monaco-editor/issues/365