Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line number API usage #740

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Fix line number API usage #740

merged 1 commit into from
Mar 8, 2018

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Mar 3, 2018

This PR fixes the samples that are using the deprecated API of lineNumbers (boolean). They now use "on", "off" and "relative".

@msftclas
Copy link

msftclas commented Mar 3, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@rebornix
Copy link
Member

rebornix commented Mar 8, 2018

@nikeee thanks for updating the API usage ;)

@rebornix rebornix merged commit 41bb016 into microsoft:master Mar 8, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikeee @msftclas @rebornix