Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add action to the left-hand-side of the diff editor #385

Closed
alexdima opened this issue Mar 1, 2017 · 0 comments
Closed

Cannot add action to the left-hand-side of the diff editor #385

alexdima opened this issue Mar 1, 2017 · 0 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
v0.8.x

Comments

@alexdima
Copy link
Member

alexdima commented Mar 1, 2017

addAction() and addContextMenu() are methods on IStandaloneEditor, but getOriginalEditor() and getModifiedEditor() return the CodeEditor instead of StandaloneCodeEditor. If I add a command to the diffEditor, then it only shows up on the modified editor, not the original editor. Previously, we could add it to both.
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Mar 1, 2017
@alexdima alexdima added this to the v0.8.x milestone Mar 1, 2017
@alexdima alexdima self-assigned this Mar 1, 2017
alexdima added a commit to microsoft/vscode that referenced this issue Mar 1, 2017
@alexdima
Fixes microsoft/monaco-editor#385
6f84579
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
v0.8.x
Development

No branches or pull requests
1 participant
@alexdima