feat(axe-core-4.6): Update axe-core to 4.6.3 #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wcag-link-data test
dbjorge
approved these changes
Feb 7, 2023
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR updates the repo to use axe-core 4.6.3
Motivation
We are updating Accessibility Insights products to use axe-core 4.6.3
Context
The first few commits represent the update to axe-core 4.6.3 and updating the main tests for the repo. The last part of the PR (handled by @shanisebarona) will update the wcag-link-data.test to account for the fact that axe-core 4.6.3 references one success criterion from WCAG 2.2.
Yes. We considered updating the converter files and related wcag-link components to account for two WCAG versions, but this proved more complicated than what seemed reasonable based on the amount of support it would provide to users. Instead, we've opted to not reference the 1 WCAG 2.2 criterion.
Pull request checklist
fix:,feat:, etc, and is suitable for user-facing release notes)BREAKING CHANGE:yarn precheckin