Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ssri to a non vulnerable version #645

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

AhmedAbdoOrtiga
Copy link
Contributor

Details

Dependabot cannot update ssri to a non-vulnerable version
The latest possible version that can be installed is 6.0.1 because of the following conflicting dependencies:

[email protected] requires ssri@^6.0.1 via a transitive dependency on [email protected]
[email protected] requires ssri@^6.0.0 via a transitive dependency on [email protected]
[email protected] requires ssri@^6.0.1 via a transitive dependency on [email protected]
[email protected] requires ssri@^6.0.1 via a transitive dependency on [email protected]
[email protected] requires ssri@^6.0.1 via a transitive dependency on [email protected]
The earliest fixed version is 8.0.1.

Motivation

Avoid security vulnerabilities.

Context

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • (if applicable) Addresses issue: #0000
  • Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@AhmedAbdoOrtiga AhmedAbdoOrtiga requested a review from a team as a code owner April 12, 2021 18:58
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a resolution is not necessary here. The references to the old ssri version go away if you instead:

  1. remove semantic-release from package.json
  2. yarn install
  3. re-add semantic-release
  4. yarn install again

@AhmedAbdoOrtiga AhmedAbdoOrtiga changed the title fix: Use Yarn resolution to update ssri fix: Update ssri to a non vulnerable version Apr 12, 2021
@AhmedAbdoOrtiga AhmedAbdoOrtiga requested a review from dbjorge April 12, 2021 21:09
@ada-cat
Copy link
Collaborator

ada-cat commented Apr 12, 2021

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DaveTryon DaveTryon deleted the ahmohame/update_ssri branch March 31, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants