Convert Extension to a string enum #16425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuit
approved these changes
Jun 10, 2017
ghost
merged commit 
mhegazy
added
API
|
@andy-ms please add a note about this change and the other namespace -> string enum changes in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes |
|
@mhegazy Done. |
mhegazy
added a commit
that referenced
this pull request
Jun 15, 2017
* Revert "Convert Extension to a string enum (#16425)" This reverts commit 09321b3. * Revert "Also convert ClassificationTypeNames and CommandTypes/CommandNames" This reverts commit f94818d. * Revert "Make ScriptElementKind and HighlightSpanKind string enums" This reverts commit b162097. * Revert "Make ScriptElementKind and HighlightSpanKind string enums" This reverts commit b162097. # Conflicts: # lib/lib.d.ts # lib/lib.es2016.full.d.ts # lib/lib.es2017.full.d.ts # lib/lib.es5.d.ts # lib/lib.es6.d.ts # lib/lib.esnext.full.d.ts # lib/tsc.js # lib/tsserver.js # lib/tsserverlibrary.d.ts # lib/tsserverlibrary.js # lib/typescript.d.ts # lib/typescript.js # lib/typescriptServices.d.ts # lib/typescriptServices.js # lib/typingsInstaller.js * Update LKG * Revert "Make CommandTypes a const enum and use `allCommandTypes` for unit test" This reverts commit f6240cb.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be backwards-compatible so long as people are accessing it as
Extension.Tsand not0.