Provide helpful error message if users try to manipulate packages without specifying any #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardWolosky
force-pushed
the
noPackages
branch
from
7e5bf8e to
ea7c6f0
Compare
| $output += "Please check your input settings to New-SubmissionPackage and ensure you're providing a value for AppxPath." | ||
| $output = $output -join [Environment]::NewLine | ||
| Write-Log $output -Level Error | ||
| throw $output |
There was a problem hiding this comment.
Can we do this with a helper method?
There was a problem hiding this comment.
A helper method wouldn't buy us much here. It's a conditional that throws a message. The only thing that I could see realistically to share out would be the error message, but at this time, I don't see sufficient value for moving it to a common place when only being shared by these two instances. Good suggestion, but won't fix.
danbelcher-MSFT
approved these changes
Dec 1, 2017
…hout specifying any If a user tries to use `-AddPackages` or `-ReplacePackages` with a StoreBroker payload that doesn't contain any, they end up with a literal `null` entry in the `applicationPackages` list due to how we manipulate the submission object. This then results in an error with the API. We should actually be catching this scenario during patching time, and providing users a helpful error message letting them know that they should check their input parameters to `New-SubmissionPackage` so that they know how to recover.
HowardWolosky
force-pushed
the
noPackages
branch
from
c25b6ec to
424d54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user tries to use
-AddPackagesor-ReplacePackageswith a StoreBroker payloadthat doesn't contain any, they end up with a literal
nullentry in theapplicationPackageslist due to how we manipulate the submission object. This then results in an error with the API.
We should actually be catching this scenario during patching time, and providing users a helpful
error message letting them know that they should check their input parameters to
New-SubmissionPackageso that they know how to recover.