Improve performance when creating output zip payload #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardWolosky
approved these changes
Sep 19, 2017
StoreBroker/PackageTool.ps1
Outdated
| Write-Log "Writing submission request JSON file: [$OutFilePath]." -Level Verbose | ||
|
|
||
| $JsonObject | | ||
| ConvertTo-Json -Depth $script:jsonConversionDepth -Compress | |
There was a problem hiding this comment.
Can you indent these additional lines?
StoreBroker/PackageTool.ps1
Outdated
| ConvertTo-Json -Depth $script:jsonConversionDepth -Compress | | ||
| Out-File -Encoding utf8 -FilePath $OutFilePath | ||
|
|
||
| Write-Log "Writing complete." -Level Verbose |
There was a problem hiding this comment.
Wasn't there value in including the $OutFilePath path in the log?
StoreBroker/PackageTool.ps1
Outdated
| Write-Log "Writing merged JSON file: [$OutJsonPath]." -Level Verbose | ||
|
|
||
| $outJsonContent | | ||
| ConvertTo-Json -Depth $script:jsonConversionDepth -Compress | |
There was a problem hiding this comment.
Can you indent these lines?
| destination. This gives better performance when the final destination is not on the local | ||
| machine. | ||
|
|
||
| The function uses no compression during the zip process, as we didn't see a noticeable |
There was a problem hiding this comment.
I'd update this comment (and the other one inside the method) to clarify that this is zipping appx/appxbundle/png files which themselves are already compressed. This wasn't a general statement on zip compression as a whole, simply for our specific use case.
…re moving to the destination. This provides better performance when the destination is on a remote machine. Additionally, add better logging so we can determine the time certain commands take to complete. Bump module version to 1.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance when creating output zip payload.
We found there was a significant delay when creating the final zip output if the output path existed on a remote machine. We will change to compress the payload on the local machine before moving the output to the final destination.
In addition, added extra logging around commands that interact with the filesystem, so that future debugging will have an easier time determining the duration of the command.
Bumped the module version to 1.9.0