Cache the AccessToken for console session to speed up successive command requests #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbelcher-MSFT
suggested changes
May 22, 2018
CHANGELOG.md
Outdated
| ## [1.16.4](https://github.com/Microsoft/StoreBroker/tree/1.16.4) - (2018/04/23) | ||
| ### Fixes: | ||
|
|
||
| - Removed checks validation checks preventing some apps from updating | ||
| - Removed checks validation checks prevented some apps from updating | ||
| gaming options or trailers. The API now enables all apps to use |
There was a problem hiding this comment.
This sentence doesn't make much sense..
| $script:lastAccessToken = $null | ||
|
|
||
| # Indicates when $script:lastAccessToken has expired and must be refreshed | ||
| $script:lastAccessTokenExpirationDate = Get-Date |
There was a problem hiding this comment.
This works but [DateTime] 0 seems more like a $null equivalent.
There was a problem hiding this comment.
Interesting. Wasn't aware of that. Will leave this as-is however, as the code seems more clear/obvious if i'm saying "it expires right now"
|
|
||
| if ($PSCmdlet.ShouldProcess("", "Clear cached access token")) | ||
| { | ||
| $script:lastAccessToken = $null |
There was a problem hiding this comment.
Do you need to reset $script:lastAccessTokenExpirationDate? Maybe this logic should move to a Clear-AccessToken function?
There was a problem hiding this comment.
We only ever use the access token if it's non-null. Will consider this feedback however.
There was a problem hiding this comment.
Decided to won't fix this.
danbelcher-MSFT
approved these changes
Jun 5, 2018
…and requests Sped up the module for users not using a Proxy. `AccessToken` is now cached for the duration of the console session, and only needs to be refreshed when it expires (which is about every 60 minutes). Previously, the access token was only cached for the duration of the currently executing command, which meant that any succesive interactions at the commandline required a new `AccessToken` to be acquired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sped up the module for users not using a Proxy.
AccessTokenis now cached for theduration of the console session, and only needs to be refreshed when it expires (which is about
every 60 minutes). Previously, the access token was only cached for the duration of the currently
executing command, which meant that any succesive interactions at the commandline required a new
AccessTokento be acquired.