Fix ConvertFrom-ExistingSubmission exception when no Advanced Listings support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o trailers While this scenario had been tested brefore, clearly something had been missed. It appears that if you pass `$null` (the result of $Submission.trailers` when the application doesn't have Advanced Listing support) to `ForEach-Object`, that iterates once (for the `$null`) which will eventually result into a call of `$null | Get-Member -Type NoteProperty` which throws an exception since you haven't passed an object to `Get-Member`. The fix is to simply switch to a standard `foreach` as opposed to the `ForEach-Object` cmdlet.
danbelcher-MSFT
approved these changes
Feb 15, 2018
| @@ -933,72 +933,72 @@ function Add-Trailers | |||
| Add-ToElement @paramSet | |||
|
|
|||
| $trailerCount = 0 | |||
| $Submission.trailers | | |||
| ForEach-Object { | |||
There was a problem hiding this comment.
Alternatively, could have added a Where-Object { $null -ne $_ } |
There was a problem hiding this comment.
Yeah, could have, but I feel like that would just add more questions as to "why would that happen?" as opposed to just using foreach where the behavior feels more clearly understood for anyone coming in to look at the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this scenario had been tested brefore, clearly something had been missed.
It appears that if you pass
$null(the result of $Submission.trailerswhen the application doesn't have Advanced Listing support) toForEach-Object, that iterates once (for the$null) which will eventually result into a call of$null | Get-Member -Type NotePropertywhich throws an exception since you haven't passed an object toGet-Member`.The fix is to simply switch to a standard
foreachas opposed to theForEach-Objectcmdlet.