Skip to content

Commit

Permalink
Fix unformatted error message when OutPath is not specified
Browse files Browse the repository at this point in the history
`Resolve-PackageParameters` has a default error message that requires
parameter formatting to be applied to it to indicate the name of the
parameter that is missing.

While it's used correctly for `OutName`, it's used incorrectly for
`OutPath`.  `$out` is already joined with newlines and only needs to
be formatted.  `$OutName` does this correctly.

Fixing `$OutPath` to leverage `$out` the same way as `$OutName`.
Specifically for `OutPath` in
  • Loading branch information
HowardWolosky committed Dec 1, 2017
1 parent 3750894 commit 6a2884d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions StoreBroker/PackageTool.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2398,9 +2398,9 @@ function Resolve-PackageParameters
$configVal = $ConfigObject.packageParameters.OutPath
if ([System.String]::IsNullOrWhiteSpace($configVal))
{
$newLineOutput = ($out -join [Environment]::NewLine)
Write-Log $newLineOutput -Level Error
throw $newLineOutput
$output = ($out -f $script:s_OutPath)
Write-Log $output -Level Error
throw $output
}
else
{
Expand Down
2 changes: 1 addition & 1 deletion StoreBroker/StoreBroker.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
CompanyName = 'Microsoft Corporation'
Copyright = 'Copyright (C) Microsoft Corporation. All rights reserved.'

ModuleVersion = '1.11.5'
ModuleVersion = '1.11.6'
Description = 'Provides command-line access to the Windows Store Submission REST API.'

RootModule = 'StoreIngestionApi'
Expand Down

0 comments on commit 6a2884d

Please sign in to comment.