Skip to content

Commit

Permalink
Avoid throwing an exception for duplicate images.
Browse files Browse the repository at this point in the history
When fallback image support was implemented, we switched to throwing an exception for duplicate images. This is actually a breaking change for users that previously had an incorrect image folder structure.  We published the change using incorrect NuGet version semantics which makes it difficult for users to rollback to the non-breaking change.  To fix, we should change to only report a warning in this case.  This will allow users with incorrect image folder structure to still successfully package as they were before. In the future, we will switch back to the exception during packaging, but we will publish the change as a new major version because it is a breaking change.
  • Loading branch information
Daniel Belcher committed Dec 14, 2017
1 parent 3df8b3f commit 4e60c5d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions StoreBroker/PackageTool.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -980,8 +980,8 @@ function Get-LocalizedMediaFile
if ($image.Count -gt 1)
{
$output = "More then one version of [$Filename] has been found for this language. Please ensure only one copy of this image exists within the language's sub-folders: [$($image.FullName -join ', ')]"
Write-Log $output -Level Error
throw $output
Write-Log $output -Level Warning
#throw $output
}

$fileFullPackagePath = Join-Path -Path $script:tempFolderPath -ChildPath $fileRelativePackagePath
Expand Down
2 changes: 1 addition & 1 deletion StoreBroker/StoreBroker.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
CompanyName = 'Microsoft Corporation'
Copyright = 'Copyright (C) Microsoft Corporation. All rights reserved.'

ModuleVersion = '1.12.1'
ModuleVersion = '1.12.2'
Description = 'Provides command-line access to the Windows Store Submission REST API.'

RootModule = 'StoreIngestionApi'
Expand Down

0 comments on commit 4e60c5d

Please sign in to comment.