Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetName hash is the same for same typed but different CLR objects #406

Closed
BernieWhite opened this issue Jan 27, 2020 · 0 comments · Fixed by #408
Closed

TargetName hash is the same for same typed but different CLR objects #406

BernieWhite opened this issue Jan 27, 2020 · 0 comments · Fixed by #408
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Member

Description of the issue

Passing a similar CLR object on the pipeline returns the same target name for different objects.

Without a bound property target name fails back to the hash method.
Each of these two object do not have the same hash, but are being serialized only based on PSObject properties which are identical.

To Reproduce

Steps to reproduce the issue:

'a','b' | Invoke-PSRule .\tests\PSRule.Tests\FromFile.Rule.ps1 -Name 'FromFile1';

Expected behaviour

Each object should have a unique target name.

Module in use and version:

  • Module: PSRule
  • Version: 0.14.0-B2001020

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      6.2.3
PSEdition                      Core
GitCommitId                    6.2.3
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional context

This affects older versions of PSRule.

@BernieWhite BernieWhite added the bug Something isn't working label Jan 27, 2020
@BernieWhite BernieWhite added this to the v0.14.0 milestone Jan 27, 2020
@BernieWhite BernieWhite self-assigned this Jan 27, 2020
BernieWhite added a commit that referenced this issue Feb 1, 2020
This was referenced Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant