Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to discover YAML options file in dotted directory #232

Closed
BernieWhite opened this issue Jul 2, 2019 · 0 comments · Fixed by #234
Closed

Failure to discover YAML options file in dotted directory #232

BernieWhite opened this issue Jul 2, 2019 · 0 comments · Fixed by #234
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Member

Description of the issue

When an default options file such as ps-rule.yaml is stored within a directory with a dotted name the file is not found.

For example C:\Temp\Rules.Test.

When a trailing slash is added the options file is correctly discovered. i.e. C:\Temp\Rules.Test\.

This is because the dotted directory name is incorrectly considered a file path instead of a directly path.

To Reproduce

Steps to reproduce the issue:

New-PSRuleOption -Path C:\Temp\Rules.Test;

Expected behaviour

The options file should be discovered in both scenarios.

Error output

Capture any error messages and or verbose messages with -Verbose.

Exception calling "FromFile" with "2" argument(s): "Options file does not exist."
At C:\Users\removed\Documents\PowerShell\Modules\PSRule\0.7.0\PSRule.psm1:727 char:13
+             $Option = [PSRule.Configuration.PSRuleOption]::FromFile($ ...
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
+ FullyQualifiedErrorId : FileNotFoundException

SetOptions : Cannot bind argument to parameter 'InputObject' because it is null.
At C:\Users\removed\Documents\PowerShell\Modules\PSRule\0.7.0\PSRule.psm1:755 char:19
+ ...       $Option | SetOptions @optionParams -Verbose:$VerbosePreference;
+                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidData: (:) [SetOptions], ParameterBindingValidationException
+ FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,SetOptions

Module in use and version:

  • Module: PSRule
  • Version: 0.7.0

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      6.2.1
PSEdition                      Core
GitCommitId                    6.2.1
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@BernieWhite BernieWhite added the bug Something isn't working label Jul 2, 2019
@BernieWhite BernieWhite added this to the v0.8.0 milestone Jul 2, 2019
@BernieWhite BernieWhite self-assigned this Jul 2, 2019
@BernieWhite BernieWhite changed the title Failure to discover yaml options file in dotted directory name Failure to discover YAML options file in dotted directory Jul 3, 2019
@BernieWhite BernieWhite mentioned this issue Aug 3, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant