Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options schema includes additionalProperties within properties block #136

Closed
BernieWhite opened this issue Apr 29, 2019 · 0 comments · Fixed by #143
Closed

Options schema includes additionalProperties within properties block #136

BernieWhite opened this issue Apr 29, 2019 · 0 comments · Fixed by #143
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Member

Description of the issue

Options schema include additionalProperties within logging options properties. additionalProperties is not a valid option that can be configured but is rather part of the JSON schema spec.

"properties": {
    "ruleFail": {
        "type": "string",
        "description": "Log fail outcomes for each rule to a specific informational stream.",
        "enum": [
            "None",
            "Error",
            "Warning",
            "Information"
        ],
        "default": "None"
    },
    "rulePass": {
        "type": "string",
        "description": "Log pass outcomes for each rule to a specific informational stream.",
        "enum": [
            "None",
            "Error",
            "Warning",
            "Information"
        ],
        "default": "None"
    },
    "additionalProperties": false
}

Expected behaviour

additionalProperties should be included outside of the properties block.

Module in use and version:

  • Module: PSRule
  • Version: 0.4.0
@BernieWhite BernieWhite added the bug Something isn't working label Apr 29, 2019
@BernieWhite BernieWhite added this to the v0.5.0 milestone Apr 29, 2019
@BernieWhite BernieWhite self-assigned this Apr 29, 2019
BernieWhite added a commit that referenced this issue Apr 30, 2019
BernieWhite added a commit that referenced this issue Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant