Implement Promise.prototype.finally #3520
Comments
|
This is stage 3, and I'm hoping to seek stage 4 in November or January; any update on this? |
|
This work is tentatively planned for the near future if we can fit it in. Earliest we can begin work on it is late October / early November. |
|
@dilijev early November is here! |
|
@ljharb Unfortunately, this didn't make the cut for our feature work on the upcoming release. We'll re-evaluate priorities and see when we can tackle this work item. |
|
@dilijev please note that I'm seeking stage 4 for it in 3 weeks; if it doesn't make it then, I'd expect it to do so in January. |
|
@ljharb at this point, it will not make it into the next Windows/Edge release. Best case the feature could be checked in to ChakraCore master and/or Node-ChakraCore, but we can't commit to anything at the moment. What is the essence of the implemented feature requirement for the process? |
|
It already has the requisite two (three, now) implementations; i was just hoping it could hit stage 4 with all 4 browsers - as is, it seems like edge will be the last to implement it. |
|
Is anyone working on this? If not I'd like to have a stab at making a PR for it. |
|
This is now stage 4, so it'd be great to get it implemented ASAP! |
|
@rhuanjl AFAIK no one is currently working on this. Feel free to take a stab at it. |
|
OK, will take me at least a week, maybe two, I'll use this comment as a tracker and post here if for any reason I don't think I can do it, please let me know at any point if it's being picked up internally (i.e. if I should drop it).
|
|
@rhuanjl test262 test cases may fail for reasons unrelated to this work (we unfortunately have thousands of test262 failures that we're tracking, probably not thousands of individual root causes). Use your best judgment but you don't have to block on test262. |
|
dilijev thanks for the heads up I'll do the best I can for spec conformance and passing the relevant tests. |
Merge pull request #4668 from rhuanjl:experiment This PR implements Promise.prototype.finally. Fixes #3520 Relevant ECMASpec: https://tc39.github.io/ecma262/#sec-promise.prototype.finally **Notes:** 1. I worked out how to do this by reading the code for Promise.prototype.catch and the internal AsyncSpawnExecutorFunction - there is a chance that some of what I've done isn't quite right though it does all seem to work. 2. I've run this against the relevant testcases from test262 and it passes them. 3. It probably could do with a few more CI tests - I added what seemed good to me based on what was there for other promise methods. 4. The large size of the diff is as I had to regenerate the bytecode for built in methods after adding the entry point for finally to JnDirectFields.h **cc:** @dilijev @ljharb Thanks to my friend @fatcerberus for running the RegenerateBytecode script for me.
Promise.prototype.finally is stage 3 - time to implement it! :-D
Test262 tests are merged.
Spec is here.
The text was updated successfully, but these errors were encountered: