Add JsGetDataViewInfo support #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Jul 31, 2017
lib/Runtime/Debug/TTEventLog.cpp
Outdated
| NSLogEvents::JsRTSingleVarArgumentAction* giAction = this->RecordGetInitializedEvent_DataOnly<NSLogEvents::JsRTSingleVarArgumentAction, NSLogEvents::EventKind::GetDataViewInfoActionTag>(); | ||
| NSLogEvents::SetVarItem_0(giAction, TTD_CONVERT_JSVAR_TO_TTDVAR(var)); | ||
|
|
||
| //entry/exit status should be set to clead by initialization so don't need to do anything |
There was a problem hiding this comment.
Typo in comment? I assume you mean clear?
There was a problem hiding this comment.
Yeah, that was actually a copy/paste so I'll fix the other one as well.
Match the existing JsGetTypedArrayInfo signature in order to support making similar queries for DataViews.
MSLaguana
approved these changes
Jul 31, 2017
|
lgtm |
chakrabot
pushed a commit
that referenced
this pull request
Jul 31, 2017
chakrabot
pushed a commit
that referenced
this pull request
Jul 31, 2017
Merge pull request #3462 from kfarnung:dataview Match the existing JsGetTypedArrayInfo signature in order to support making similar queries for DataViews.
| /// The code <c>JsNoError</c> if the operation succeeded, a failure code otherwise. | ||
| /// </returns> | ||
| CHAKRA_API | ||
| JsGetDataViewInfo( |
There was a problem hiding this comment.
There is very similar API JsGetDataViewStorage. Can we reuse this? What is the use-case?
There was a problem hiding this comment.
Yeah, I thought the same thing at first, but that method is purely interested in the raw storage. This method returns the parameters which were passed to the create method and I couldn't see a good way to get them (other than using script). Since TypedArray and DataView are both views over an ArrayBuffer, I think it makes sense for them to have similar interaction models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the existing JsGetTypedArrayInfo signature in order to support
making similar queries for DataViews.