Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission in NETSTANDARD target does not handle partial success. #1047

Closed
cijothomas opened this issue Jan 8, 2019 · 0 comments
Closed
Assignees
Milestone

Comments

@cijothomas
Copy link
Contributor

For Netstandard target, transmission does not handle partial response from backend. It simply returns null, so PartialSuccessTransmissionPolicy won't have a chance to resend the rejected items later.
https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/src/Microsoft.ApplicationInsights/Channel/Transmission.cs#L171

It also looks like the Transmission class was missing Unit Tests as well as UnitTests was only targeting the full .NET Framework.
https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/Test/Microsoft.ApplicationInsights.Test/Shared/Channel/TransmissionTest.cs#L13

Proposal is to remove the multiple implementations, and move everything to use HttpClient and add unit test coverage. (The reason why separate implementation existed earlier was targeting NET40 which is no longer the case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant