Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument newer versions of the postgres jdbc SDK #749

Closed
timja opened this issue Sep 24, 2018 · 1 comment
Closed

Instrument newer versions of the postgres jdbc SDK #749

timja opened this issue Sep 24, 2018 · 1 comment
Milestone

Comments

@timja
Copy link
Contributor

timja commented Sep 24, 2018

Is your feature request related to a problem? Please describe.
Postgres is not instrumented correctly by the agent

Describe the solution you would like
Update the code to support newer postgres SDK versions

Describe alternatives you have considered
We're currently manually instrumenting using the agent XML in some places but we have a lot of java applications that are missing out on this functionality.

Additional context
Need to update these lines of code:
https://github.com/Microsoft/ApplicationInsights-Java/blob/master/agent/src/main/java/com/microsoft/applicationinsights/agent/internal/agent/sql/PreparedStatementClassDataProvider.java#L63
https://github.com/Microsoft/ApplicationInsights-Java/blob/master/agent/src/main/java/com/microsoft/applicationinsights/agent/internal/agent/sql/PreparedStatementClassDataProvider.java#L222

To handle this commit:
pgjdbc/pgjdbc@42c2e3b#diff-fc136162d0d2039cce76db7d26c9ba04

Specifically the rename from:
AbstractJdbc2Connection -> PgConnection

@dhaval24
Copy link
Contributor

@timja thank you very much for raising a feature request. PostGres, is something we don't have official auto collection support for, and hence you see its untouched for long. We will take this as a feature request and triage it to future feature releases.

@nikmd23, here is a feature request for PostGres.

@timja by the way, feel free to submit a PR if you would be willing to contribute to the project. We welcome all contributions!

@dhaval24 dhaval24 added this to the future milestone Sep 25, 2018
@timja timja closed this as completed Mar 14, 2019
dhaval24 pushed a commit that referenced this issue Mar 15, 2019
…t instrumentation (#846)

* WIP: Fix postgres instrumentation

#749

* Fixes for PG prepared statement signature

* Fixes for PG prepared statement signature

* Use single ctor

* Add note on changes needed to add other pg constructor

* Clean up

* Remove note about unused constructor

* Update changelog

* Update application version

* Update application version to 2.5.0

* Fix version
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants