Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 17 #401

Open
5 tasks
KyleAure opened this issue Dec 13, 2023 · 5 comments
Open
5 tasks

Upgrade to Java 17 #401

KyleAure opened this issue Dec 13, 2023 · 5 comments
Assignees
@inteqam
Labels
good first issue Good for newcomers is:housekeeping A maintenance task
Milestone
1.0.0

Comments

@KyleAure
Copy link
Collaborator

KyleAure commented Dec 13, 2023 •
edited
Loading

We should upgrade to building and testing using Java 17 as a stepping stone to Java 21 (Necessary for Jakarta EE 11).

  • If necessary upgrade gradle wrapper
  • Update build.gradle (source/target compatibility)
  • Update pom.xml within sample-apps/ (source/target compatibility)
  • Update CI Workflow to build and run using Java 17
  • Update documentation
@KyleAure KyleAure added good first issue Good for newcomers is:housekeeping A maintenance task labels Dec 13, 2023
@KyleAure KyleAure added this to the 0.9.3 milestone Dec 13, 2023
@inteqam
Copy link

inteqam commented Dec 15, 2023

Hi, I am new to contribution and i love to contribute can u assign this to me?

@KyleAure
Copy link
Collaborator Author

@inteqam I have assigned this issue to you. Let me know if you need any help from me. Welcome to Microshed Testing. 😁

@appiepollo14
Copy link
Collaborator

@inteqam how are you progressing? Can you show it via a draft PR?

@appiepollo14
Copy link
Collaborator

@KyleAure I've my doubts whether this is the correct way to go at this moment. I believe we need to aim at the lowest possible Java version for microshed to keep it useful for as many users as possible. When we build with java 17, we already raise the minimal Java version for users to Java 17, without any functional progress as we don't have features depending on Java 17/21 features. Jakarta 11 isn't here yet. Let's postpone this change until it's there.

@KyleAure KyleAure modified the milestones: 0.9.3, 1.0.0 Jan 3, 2024
@KyleAure
Copy link
Collaborator Author

KyleAure commented Jan 3, 2024

Agreed, moved the milestone to 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inteqam inteqam

Labels
good first issue Good for newcomers is:housekeeping A maintenance task
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@appiepollo14 @KyleAure @inteqam