Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow basic authentication header on injected @RESTClients #157

Closed
jlf-ibm opened this issue Feb 29, 2020 · 3 comments · Fixed by #158
Closed

allow basic authentication header on injected @RESTClients #157

jlf-ibm opened this issue Feb 29, 2020 · 3 comments · Fixed by #158
Labels
is:enhancement New feature or request

Comments

@jlf-ibm
Copy link

jlf-ibm commented Feb 29, 2020

Is your feature request related to a problem? Please describe.

We already support attaching JWTs to RESTClient instances. Allow another type in that same vein, for setting HTTP Basic Authentication header.

Describe the solution you'd like

@RESTClient
@BasicAuthConfig(username = "user", password="pass")
MyClientResource myClient;

Describe alternatives you've considered

The only alternative is to completely change my application to use JWTs instead of in-container basic authentication.

Additional context

Open Liberty 19 with standard LDAP registry and web.xml with ALL_CONFIDENTIAL protecting /*

@jlf-ibm jlf-ibm added the is:enhancement New feature or request label Feb 29, 2020
@aguibert
Copy link
Member

aguibert commented Mar 2, 2020

Thanks for opening this @jlf-ibm, sounds like a good use case to support. I wonder if we should use a more generic annotation approach so we don't need to make a new annotation for every authentication or header type?

@jlf-ibm
Copy link
Author

jlf-ibm commented Mar 2, 2020

Maybe if we add a third? I leave it to you. It'd be nice to just get this specific in sooner than a generic later.

@aguibert
Copy link
Member

aguibert commented Mar 3, 2020

Hi @jlf-ibm, I wrote up a proposed PR here and will merge it soon:
#158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants