Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TomEE adapter module #105

Open
aguibert opened this issue Nov 11, 2019 · 0 comments
Open

Create TomEE adapter module #105

aguibert opened this issue Nov 11, 2019 · 0 comments
Labels
good first issue Good for newcomers is:enhancement New feature or request
Milestone

Comments

@aguibert
Copy link
Member

Describe the solution you'd like
Currently the OpenLiberty and Payara runtimes have dedicated modules that provide some helpful default configuration like:

  • default ports
  • default dockerfile instructions

It would be nice if TomEE also had a default module so users are not required to have a Dockerfile

Describe alternatives you've considered
It is still possible to use MicroShed Testing on a TomEE app without a dedicated TomEE adapter module, but this relies on:

  • Inspecting the docker container for exposed port on each run (adds about a second to the test runtime)
  • the user having a Dockerfile in their repo (if building the app from source)

Additional context
Write an adapter involves implementing the org.microshed.testing.testcontainers.spi.ServerAdapter interface in a new module. See the Payara micro adapter for a minimal example

@aguibert aguibert added is:enhancement New feature or request good first issue Good for newcomers labels Nov 11, 2019
@KyleAure KyleAure added this to the 1.0.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers is:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants