diff --git a/modules/liberty/src/main/java/org/testcontainers/containers/liberty/LibertyAdapter.java b/modules/liberty/src/main/java/org/testcontainers/containers/liberty/LibertyAdapter.java index ac9787d3..929cd1d2 100644 --- a/modules/liberty/src/main/java/org/testcontainers/containers/liberty/LibertyAdapter.java +++ b/modules/liberty/src/main/java/org/testcontainers/containers/liberty/LibertyAdapter.java @@ -26,7 +26,6 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; -import java.util.Optional; import org.microshed.testing.testcontainers.spi.ServerAdapter; import org.testcontainers.images.builder.ImageFromDockerfile; @@ -46,7 +45,7 @@ public static void setBaseDockerImage(String imageName) { @Override public int getPriority() { - return -50; + return PRIORITY_RUNTIME_MODULE; } @Override @@ -113,8 +112,4 @@ public ImageFromDockerfile getDefaultImage(File appFile) { return image; } - @Override - public Optional getReadinessPath() { - return Optional.empty(); - } } diff --git a/modules/payara-micro/src/main/java/org/testcontainers/containers/payara/PayaraMicroAdapter.java b/modules/payara-micro/src/main/java/org/testcontainers/containers/payara/PayaraMicroAdapter.java index 0b874160..ecfd9a80 100644 --- a/modules/payara-micro/src/main/java/org/testcontainers/containers/payara/PayaraMicroAdapter.java +++ b/modules/payara-micro/src/main/java/org/testcontainers/containers/payara/PayaraMicroAdapter.java @@ -25,6 +25,12 @@ import java.util.Optional; public class PayaraMicroAdapter implements ServerAdapter { + + @Override + public int getPriority() { + return PRIORITY_RUNTIME_MODULE; + } + @Override public int getDefaultHttpPort() { return 8080; diff --git a/modules/payara-server/src/main/java/org/testcontainers/containers/payara/PayaraServerAdapter.java b/modules/payara-server/src/main/java/org/testcontainers/containers/payara/PayaraServerAdapter.java index 5fca9f28..7ca8ab4f 100644 --- a/modules/payara-server/src/main/java/org/testcontainers/containers/payara/PayaraServerAdapter.java +++ b/modules/payara-server/src/main/java/org/testcontainers/containers/payara/PayaraServerAdapter.java @@ -25,6 +25,12 @@ import java.util.Optional; public class PayaraServerAdapter implements ServerAdapter { + + @Override + public int getPriority() { + return PRIORITY_RUNTIME_MODULE; + } + @Override public int getDefaultHttpPort() { return 8080; diff --git a/modules/testcontainers/src/main/java/org/microshed/testing/testcontainers/spi/ServerAdapter.java b/modules/testcontainers/src/main/java/org/microshed/testing/testcontainers/spi/ServerAdapter.java index cb4a2db8..50abaaaf 100644 --- a/modules/testcontainers/src/main/java/org/microshed/testing/testcontainers/spi/ServerAdapter.java +++ b/modules/testcontainers/src/main/java/org/microshed/testing/testcontainers/spi/ServerAdapter.java @@ -38,8 +38,12 @@ */ public interface ServerAdapter { + static final int PRIORITY_USER_DEFAULT = 50; + static final int PRIORITY_DEFAULT = 0; + static final int PRIORITY_RUNTIME_MODULE = -50; + default int getPriority() { - return 0; + return PRIORITY_DEFAULT; } /** @@ -91,8 +95,10 @@ default ImageFromDockerfile getDefaultImage(File appFile) { /** * Defines the readiness path for the Server which will be used by default when the developer did not specify such value. - * The implementation can choose to return null and then no value is defined by default. - * @return the readiness path to be used by default. + * + * @return the readiness path to be used by default, or an empty Optional if no default value is provided. */ - Optional getReadinessPath(); + default Optional getReadinessPath() { + return Optional.empty(); + } } diff --git a/sample-apps/liberty-app/build.gradle b/sample-apps/liberty-app/build.gradle index 840822e8..e7c7fe8a 100644 --- a/sample-apps/liberty-app/build.gradle +++ b/sample-apps/liberty-app/build.gradle @@ -5,7 +5,6 @@ plugins { dependencies { providedCompile 'javax:javaee-api:8.0.1' providedCompile 'org.eclipse.microprofile:microprofile:3.0' - testCompile project(':microshed-testing-testcontainers') testCompile project(':microshed-testing-liberty') testCompile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.29' testImplementation 'org.junit.jupiter:junit-jupiter:5.5.2' diff --git a/sample-apps/payara-app/Dockerfile b/sample-apps/payara-app/Dockerfile deleted file mode 100644 index 3d8c84d5..00000000 --- a/sample-apps/payara-app/Dockerfile +++ /dev/null @@ -1,4 +0,0 @@ -# Payara -FROM payara/micro:5.193 -CMD ["--deploymentDir", "/opt/payara/deployments", "--noCluster"] -ADD build/libs/myservice.war /opt/payara/deployments diff --git a/sample-apps/payara-app/build.gradle b/sample-apps/payara-app/build.gradle index 818f1670..3610ae94 100644 --- a/sample-apps/payara-app/build.gradle +++ b/sample-apps/payara-app/build.gradle @@ -5,7 +5,7 @@ plugins { dependencies { providedCompile 'javax:javaee-api:8.0.1' providedCompile 'org.eclipse.microprofile:microprofile:2.1' - testCompile project(':microshed-testing-testcontainers') + testCompile project(':microshed-testing-payara-server') testCompile group: 'org.slf4j', name: 'slf4j-log4j12', version: '1.7.29' testImplementation 'org.junit.jupiter:junit-jupiter:5.5.2' }