Change how we write to stderr from CoreLib (dotnet#1377)

We write to stderr from CoreLib for two reasons:

1. FailFast
2. Unhandled exception (also FailFast in a way)

We're using a roundabout way to use `Console.Error.WriteLine` but that has problems for FailFast because we then don't fail fast enough (dotnet#1277).

This inlines enough of writing to stderr that we can get rid of System.Console dependency.

Fixes dotnet#1277.

Author: MichalStrehovsky

docs/using-nativeaot/optimizing.md

@@ -49,5 +49,4 @@ Debugging symbols (data about your program required for debugging) is by default
 No action is needed on Windows since the platform convention is to generate debug information into a separate file (`*.pdb`).
 
 ## Advanced options 
-* `<IlcDisableUnhandledExceptionExperience>true</IlcDisableUnhandledExceptionExperience>`: disables code that prints stack traces for unhandled exceptions to the console.
 * `<IlcSystemModule>classlibmodule</IlcSystemModule>`: Name of the module which contains basic classes. When specified, disable automatic referencing of the `System.Private.CoreLib` and other libraries. See https://github.com/MichalStrehovsky/zerosharp for example of usage.

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

@@ -98,7 +98,6 @@ The .NET Foundation licenses this file to you under the MIT license.
     <AutoInitializedAssemblies Include="System.Private.Reflection.Execution" Condition="$(IlcDisableReflection) != 'true'" />
     <AutoInitializedAssemblies Include="System.Private.DisabledReflection" Condition="$(IlcDisableReflection) == 'true'" />
     <AutoInitializedAssemblies Include="System.Private.Interop" />
-    <AutoInitializedAssemblies Include="System.Private.DeveloperExperience.Console" Condition="$(IlcDisableUnhandledExceptionExperience) != 'true'"  />
   </ItemGroup>
 
   <ItemGroup>

src/coreclr/nativeaot/System.Private.CoreLib/src/Internal/DeveloperExperience/DeveloperExperience.cs

@@ -33,22 +33,6 @@ private static bool IsMetadataStackTraceResolutionDisabled()
             return disableMetadata;
         }
 
-        internal static void WriteLine(string s)
-        {
-            // We need to write into stderr, but CoreLib doesn't have a way to write to stderr, so we rely
-            // on a separate library on the startup path to hook this up.
-            // If nothing hooked it up, just use Debug.WriteLine.
-            Action<string> writeLineMethod = AppContext.GetData("System.Runtime.ExceptionServices.WriteLine") as Action<string>;
-            if (writeLineMethod != null)
-            {
-                writeLineMethod(s);
-            }
-            else
-            {
-                Debug.WriteLine(s);
-            }
-        }
-
         public virtual string CreateStackTraceString(IntPtr ip, bool includeFileInfo)
         {
             if (!IsMetadataStackTraceResolutionDisabled())

src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs

@@ -1,13 +1,11 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime;
 using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
-using System.Threading;
+
 using Internal.DeveloperExperience;
 using Internal.Runtime.Augments;
 
@@ -241,10 +239,23 @@ internal static void FailFast(string message, Exception exception, RhFailFastRea
 
             if (!minimalFailFast)
             {
-                string output = (exception != null) ?
-                    "Unhandled Exception: " + exception.ToString()
-                    : message;
-                DeveloperExperience.WriteLine(output);
+                string prefix;
+                string outputMessage;
+                if (exception != null)
+                {
+                    prefix = "Unhandled Exception: ";
+                    outputMessage = exception.ToString();
+                }
+                else
+                {
+                    prefix = "Process terminated. ";
+                    outputMessage = message;
+                }
+
+                Internal.Console.Error.Write(prefix);
+                if (outputMessage != null)
+                    Internal.Console.Error.Write(outputMessage);
+                Internal.Console.Error.Write(Environment.NewLine);
 
 #if FEATURE_DUMP_DEBUGGING
                 GenerateExceptionInformationForDump(exception, IntPtr.Zero);

src/coreclr/tools/aot/ILCompiler/repro/repro.csproj

@@ -27,7 +27,6 @@
       <ReproResponseLines Include="--initassembly:System.Private.TypeLoader" />
       <ReproResponseLines Include="--initassembly:System.Private.Reflection.Execution" />
       <ReproResponseLines Include="--initassembly:System.Private.Interop" />
-      <ReproResponseLines Include="--initassembly:System.Private.DeveloperExperience.Console" />
       <ReproResponseLines Include="--directpinvokelist:$(RuntimeBinDir)build\WindowsAPIs.txt" />
       <ReproResponseLines Include="--stacktracedata" />
       <ReproResponseLines Include="--scanreflection" />

src/libraries/Common/src/Interop/Unix/System.Native/Interop.Log.cs

@@ -10,5 +10,8 @@ internal static partial class Sys
     {
         [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_Log")]
         internal static extern unsafe void Log(byte* buffer, int count);
+
+        [DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_LogError")]
+        internal static extern unsafe void LogError(byte* buffer, int count);
     }
 }

src/libraries/Native/Unix/System.Native/entrypoints.c

@@ -112,6 +112,7 @@ static const Entry s_sysNative[] =
     DllImportEntry(SystemNative_LChflagsCanSetHiddenFlag)
     DllImportEntry(SystemNative_ReadProcessStatusInfo)
     DllImportEntry(SystemNative_Log)
+    DllImportEntry(SystemNative_LogError)
     DllImportEntry(SystemNative_AlignedAlloc)
     DllImportEntry(SystemNative_AlignedFree)
     DllImportEntry(SystemNative_AlignedRealloc)

src/libraries/Native/Unix/System.Native/pal_log.c

@@ -11,3 +11,9 @@ void SystemNative_Log(uint8_t* buffer, int32_t length)
     fwrite(buffer, 1, (size_t)length, stdout);
     fflush(stdout);
 }
+
+void SystemNative_LogError(uint8_t* buffer, int32_t length)
+{
+    fwrite(buffer, 1, (size_t)length, stderr);
+    fflush(stderr);
+}

src/libraries/Native/Unix/System.Native/pal_log.h

@@ -7,3 +7,4 @@
 #include "pal_types.h"
 
 PALEXPORT void SystemNative_Log(uint8_t* buffer, int32_t length);
+PALEXPORT void SystemNative_LogError(uint8_t* buffer, int32_t length);

src/libraries/Native/Unix/System.Native/pal_log.m

@@ -39,3 +39,8 @@ void SystemNative_Log (uint8_t* buffer, int32_t length)
     }
     [msg release];
 }
+
+void SystemNative_LogError (uint8_t* buffer, int32_t length)
+{
+    SystemNative_Log (buffer, length);
+}

src/libraries/NetCoreAppLibrary.props

@@ -77,7 +77,6 @@
       System.Numerics.Vectors;
       System.ObjectModel;
       System.Private.DataContractSerialization;
-      System.Private.DeveloperExperience.Console;
       System.Private.Runtime.InteropServices.JavaScript;
       System.Private.Uri;
       System.Private.Xml;

src/libraries/System.Private.CoreLib/src/Internal/Console.Unix.cs

@@ -16,5 +16,17 @@ public static unsafe void Write(string s)
                 Interop.Sys.Log(pBytes, bytes.Length);
             }
         }
+
+        public static partial class Error
+        {
+            public static unsafe void Write(string s)
+            {
+                byte[] bytes = Encoding.UTF8.GetBytes(s);
+                fixed (byte* pBytes = bytes)
+                {
+                    Interop.Sys.LogError(pBytes, bytes.Length);
+                }
+            }
+        }
     }
 }

src/libraries/System.Private.CoreLib/src/Internal/Console.Windows.cs

@@ -8,15 +8,36 @@ namespace Internal
 {
     public static partial class Console
     {
-        private static readonly IntPtr s_outputHandle =
-            Interop.Kernel32.GetStdHandle(Interop.Kernel32.HandleTypes.STD_OUTPUT_HANDLE);
+        public static void Write(string s)
+        {
+            WriteCore(Interop.Kernel32.GetStdHandle(Interop.Kernel32.HandleTypes.STD_OUTPUT_HANDLE), s);
+        }
+
+        public static partial class Error
+        {
+            public static void Write(string s)
+            {
+                WriteCore(Interop.Kernel32.GetStdHandle(Interop.Kernel32.HandleTypes.STD_ERROR_HANDLE), s);
+            }
+        }
 
-        public static unsafe void Write(string s)
+        private static unsafe void WriteCore(IntPtr handle, string s)
         {
-            byte[] bytes = Encoding.UTF8.GetBytes(s);
+            int bufferSize = s.Length * 4;
+            Span<byte> bytes = bufferSize < 1024 ? stackalloc byte[bufferSize] : new byte[bufferSize];
+            int cbytes;
+
+            fixed (char* pChars = s)
+            fixed (byte* pBytes = bytes)
+            {
+                cbytes = Interop.Kernel32.WideCharToMultiByte(
+                    Interop.Kernel32.GetConsoleOutputCP(),
+                    0, pChars, s.Length, pBytes, bytes.Length, IntPtr.Zero, IntPtr.Zero);
+            }
+
             fixed (byte* pBytes = bytes)
             {
-                Interop.Kernel32.WriteFile(s_outputHandle, pBytes, bytes.Length, out _, IntPtr.Zero);
+                Interop.Kernel32.WriteFile(handle, pBytes, cbytes, out _, IntPtr.Zero);
             }
         }
     }

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems

@@ -1511,6 +1511,9 @@
     <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetComputerName.cs">
       <Link>Common\Interop\Windows\Kernel32\Interop.GetComputerName.cs</Link>
     </Compile>
+    <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetConsoleOutputCP.cs">
+      <Link>Common\Interop\Windows\Kernel32\Interop.GetConsoleOutputCP.cs</Link>
+    </Compile>
     <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetCPInfo.cs">
       <Link>Common\Interop\Windows\Kernel32\Interop.GetCPInfo.cs</Link>
     </Compile>

src/libraries/System.Private.DeveloperExperience.Console/Directory.Build.props

@@ -4830,11 +4830,6 @@
         "4.1.2.0": "4.3.0"
       }
     },
-    "System.Private.DeveloperExperience.Console": {
-      "InboxOn": {
-        "net5.0": "5.0.0.0"
-      }
-    },
     "System.Private.Runtime.InteropServices.JavaScript": {
       "InboxOn": {
         "net5.0": "5.0.0.0",