-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate zig package #6
base: master
Are you sure you want to change the base?
Conversation
Thank you! Could you make the new logic conditional on some property so people who want to use Zig that they already have installed can do so (and the NuGet doesn't download)? Would you mind updating the README.md too? |
Done. PTAL. |
Co-authored-by: Michal Strehovský <[email protected]>
I tried this out in a Windows Sandbox and it doesn't quite work (the package doesn't get downloaded and the property that should have path to the package is empty). I think it's because one cannot reference new NuGets from a .targets that is in a NuGet itself. NuGet restore doesn't see it and it kind of makes sense. NuGet restore is a different codepath from what the test project in this repo uses :/. |
I'm wondering how does the |
There's some special logic for that in the sdk. I think nuget has a way to express this package depends on something else in the package metadata. That's the normal way. Ilcompiler is definitely not normal in this sense, don't look at that |
|
Adding a note of what I wrote on Discord: can we build this in a way that requires users to add |
It seems like that's the least painful way forward. Those packages will set I think we'd need some docs to point to that would explain that the recommended usage pattern for those packages is something like: <Project Sdk="Microsoft.NET.Sdk">
...
<ItemGroup>
<PackageReference Include="Vezel.Zig.Toolsets.$(NETCoreSdkPortableRuntimeIdentifier)"
Version="0.12.0.*"
PrivateAssets="all" />
</ItemGroup>
...
</Project> That can probably just go in the README or something. |
Looks great, any progress on this PR? |
Closes #5