-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't limit to 10k concealed strings #96
Comments
Also happens in stringEncoding, and other concealment transformations |
How many strings do you need encoded? I felt like creating a massive string array would be detrimental to performance so I added a limit. And the improper |
The problem I see is that it goes top-to-bottom, so the end of the script often has no string concealment. We have a lot of auto-generated code that easily surpasses 50k strings and just an enormous code base in general. |
I agree that the limit should not be present. The developer using the obfuscator can control the amount of strings that are in the string array by changing the probability. Hard-coding this takes away control and makes the obfuscator not suitable for my use-case. @MichaelXF I'd be willing to submit a PR to remove these hard-coded limits. |
Is your feature request related to a problem? Please describe.
I am hitting the limit here:
js-confuser/src/transforms/string/stringConcealing.ts
Line 196 in 30e4043
Why does it exist?
Also, the
!
is causing the chance to be 10% instead of 90% when exceeding 1k due to the improper!
.The text was updated successfully, but these errors were encountered: