Address code review comments

Removed the superfluous check testing whether fill_value was a NaN or not (in pandas/core/arrays/masked.py::take).

pylint properly flags an unnecessary implementation of TestGroupby.test_groupby_agg_extension (which merely calls the parent method by the same name).  By deleting that implementation, the parent method is called automatically.

Signed-off-by: Michael Tiemann <[email protected]>

Author: MichaelTiemannOSC

pandas/core/arrays/masked.py

@@ -872,7 +872,7 @@ def take(
         # TODO(jreback) what if we have a non-na float as a fill value?
         # NaN with uncertainties is scalar but does not register as `isna`,
         # so use fact that NaN != NaN
-        if allow_fill and notna(fill_value) and fill_value == fill_value:
+        if allow_fill and notna(fill_value):
             fill_mask = np.asarray(indexer) == -1
             result[fill_mask] = fill_value
             mask = mask ^ fill_mask

pandas/tests/extension/json/test_json.py

@@ -356,9 +356,6 @@ def test_groupby_extension_no_sort(self):
         """
         super().test_groupby_extension_no_sort()
 
-    def test_groupby_agg_extension(self, data_for_grouping):
-        super().test_groupby_agg_extension(data_for_grouping)
-
 
 class TestArithmeticOps(BaseJSON, base.BaseArithmeticOpsTests):
     def test_arith_frame_with_scalar(self, data, all_arithmetic_operators, request):