-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognise magic methods #81
base: main
Are you sure you want to change the base?
Conversation
I see that the linting check failed, but that seems to because of the job setup rather than because of my code (?) If you can let me know how to fix it I'd be happy to adjust as needed. |
Yep lining is broken but its not your fault :) I'll fix it on main, I'll let you know when to rebase |
docstring | ||
elif | ||
endswith | ||
enum | ||
env | ||
environ | ||
eq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would only allow theses exclusively in the context of __ __
. But right now there is no way to do that in flake8-spellcheck
Something for me to consider in the future :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - did think of that, especially the 2-letter names
I did some investigation, but not obvious how to achieve that
@jalanb please rebase on latest |
Rebased from upstream's main, lints failed on All tests now passing |
Pull upstream changes
Test a Python class with all possible dunder methods
These are valid names for magic methods But are already recognised as English (en_US)
Fixes #80
Adds the missing names to
python.txt
Adds a test case to check a Python
class
which includes every possible magic method name