Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peaks near the border of a bin are split #11

Open
elliotfontaine opened this issue Jun 11, 2024 · 0 comments
Open

Peaks near the border of a bin are split #11

elliotfontaine opened this issue Jun 11, 2024 · 0 comments
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@elliotfontaine
Copy link
Contributor

During feature extraction, some peaks located at either end of bins can get split because of how binning works. Intensity is lower than it should be.

BinneR gives a quality control metrics, "centrality", that can help mitigate this issue. If two neighbor bins have low centrality and assigned m/z values that are very close, then they should be merged: drop one on the two values, and sum the intensity.

@elliotfontaine elliotfontaine added the type:bug Something isn't working label Jun 11, 2024
@elliotfontaine elliotfontaine self-assigned this Jun 11, 2024
@elliotfontaine elliotfontaine added this to the 0.1.0 milestone Jun 11, 2024
@elliotfontaine elliotfontaine changed the title Fix peak splitting occuring with binneR Peaks near the border of a bin are split Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant