-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement batch transactions #18
Comments
We will have to use It is not well documented, but as far as I can tell from the discussion here ethers-io/ethers.js#62 (comment), the provider can be instantiated the way the ethers provider is within the current test dapp code. Then you can create multiple transactions as is done in the example here: https://ethereum.stackexchange.com/a/77169 But instead of awaiting each of them, create them all and then await a |
@danjm During the refinement we made a conclusion that the best approach to achieve this is to create a new button on the test-dapp which will call wrapped function that will perform few transactions in a batch which will target our deployed smart contract. AC:
Couple of arguments for the proposal is:
|
This proposal sounds good to me. Are there any other blockers to this? |
Blocked by PR: #137 |
Because of limitation of ethers library we've decided to integrate web3 library into the test-dapp. Web3 library with its functionality will make batch transactions possible. |
We should add batch transaction functionality to the test dapp, for testing.
We should follow this:
https://codesandbox.io/s/metamask-batchrequest-bug-demo-emnph
Zipped:
metamask-batchrequest-bug-demo.zip
Contract on Rinkeby:
https://rinkeby.etherscan.io/address/0xfac5d594548b1ab5fb724d8011187ec51919b92e#code
Context:
MetaMask/metamask-extension#5852 (comment)
The text was updated successfully, but these errors were encountered: