Added out of band error support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested changes
Sep 24, 2021
packages/controllers/src/services/WebWorkerExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
shanejonas
commented
Sep 24, 2021
| @@ -66,6 +67,7 @@ describe('Iframe Controller', () => { | |||
| await expect(action()).rejects.toThrow( | |||
| /Error while running plugin 'TestPlugin'/u, | |||
| ); | |||
| await iframeExecutionEnvironmentService.terminateAllPlugins(); | |||
There was a problem hiding this comment.
added terminateAllPlugins here because when testing it wasn't cleaning up the plugin from the page
shanejonas
force-pushed
the
add-out-of-band-errors
branch
from
67b6a3d
to
41bff4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds out of band error support to the IframeExecutionEnvironmentService and WebWorkerEnvironmentService via the
onErrorconstructor argument.Note: I'm unable to add the tests for this, I'm hitting this issue around handling uncaught/unhandled errors: jestjs/jest#5620