@metamask/[email protected] #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
commented
Aug 31, 2021
| "@metamask/object-multiplex": "^1.1.0", | ||
| "@metamask/obs-store": "^6.0.2", | ||
| "@metamask/post-message-stream": "4.0.0", | ||
| "@metamask/safe-event-emitter": "^2.0.0", | ||
| "@mm-snap/workers": "^0.0.6", | ||
| "eth-rpc-errors": "^4.0.2", | ||
| "immer": "^8.0.4", |
There was a problem hiding this comment.
This is the version used by @metamask/controllers.
rekmarks
added a commit
that referenced
this pull request
Sep 7, 2021
We exorcised the demons from our `eslint` config, and how this is a temple of clean and syntactical code once again. 🙏 - Remove the MetaMask TypeScript eslint rules - TIL this breaks eslint for JavaScript - Update eslint config for our different globals and environments - Remove TypeScript and `jest`-related eslint dependencies and configs - Fix a lot of eslint errors - Fix a lot of `async`/`await` syntax errors - These were concealed by the eslint demons. Fixing them sometimes involved wrapping `await`:ed expressions in `async` functions. - Fix `createWriteStream` import (it's not part of `fs.promises`) - Remove `.npmignore`, add `files` property to package.json - Update `.gitignore`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the latest
@metamask/controllers. This version adds the controller messenger type as a generic toBaseControllerV2, so thePluginControllerhad to be updated to be made compatible.As a follow-up, we should also do #65.