Added reset plugins running state in PluginController constructor to … #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
reset-plugins-running-on-boot-not-runningn
branch
from
44fec51 to
8d5c279
Compare
shanejonas
commented
Aug 31, 2021
shanejonas
force-pushed
the
reset-plugins-running-on-boot-not-runningn
branch
from
855a14f to
119c11c
Compare
rekmarks
requested changes
Aug 31, 2021
| }), | ||
| state: persistedState as unknown as PluginControllerState, | ||
| }); | ||
| await secondPluginController.runExistingPlugins(); |
There was a problem hiding this comment.
I think we should check the value of isRunning for the plugin foo immediately before and after this call.
rekmarks
added a commit
that referenced
this pull request
Sep 7, 2021
* add eslint and fix related errors * isFile and isDirectory refactor * remove bundle.js file in identicon example * add linting scripts * update eslint overrides Co-authored-by: Erik Marks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue im hitting where in the hydrated state case it ends up deleting the plugin, this fix resets it to not running so it can be booted cleanly with
runExistinPlugins.to fully resolve this issue, metamask-extension needs to handle
getPersistedStatewhen appropriate