Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed updatePluginState to use proper key pluginStates #48

Merged
merged 8 commits into from
Aug 16, 2021

Conversation

shanejonas
Copy link
Contributor

this was a mistake converting it from the old BaseController

@shanejonas shanejonas requested a review from rekmarks August 16, 2021 19:41
@shanejonas shanejonas requested a review from a team August 16, 2021 19:57
@shanejonas shanejonas requested a review from rekmarks August 16, 2021 20:10
@shanejonas shanejonas force-pushed the fix-update-plugin-state branch from c84c35d to 46631be Compare August 16, 2021 20:33
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanejonas shanejonas merged commit bc5238e into main Aug 16, 2021
@shanejonas shanejonas deleted the fix-update-plugin-state branch August 16, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants