refactor plugin + worker interface #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
refactor-plugin-worker-interface
branch
2 times, most recently
from
e6ad72e
to
6356a42
Compare
shanejonas
force-pushed
the
refactor-plugin-worker-interface
branch
from
6356a42
to
a30a344
Compare
shanejonas
changed the title
shanejonas
commented
Jun 14, 2021
shanejonas
commented
Jun 14, 2021
shanejonas
commented
Jun 14, 2021
shanejonas
commented
Jun 14, 2021
rekmarks
requested changes
Jun 14, 2021
There was a problem hiding this comment.
This is a great start!
I have a couple of significant change requests that I left and explain inline.
In addition to those, I think it's worth considering how the current execution environment (EE) service interface will work when we have multiple EEs. Ideally, there should be a single EE service class that's capable of starting a plugin in any conceivable EE. In that paradigm, the worker EE service would be a sub-service of that uber-EE service. As I mention inline, I believe that some of the existing public methods of the service interface are too low-level for the plugin controller, but they would be completely appropriate for a class that manages multiple EE services.
packages/controllers/src/services/WorkerExecutionEnvironment.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/WorkerExecutionEnvironment.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/WorkerExecutionEnvironment.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/WorkerExecutionEnvironment.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/WorkerExecutionEnvironment.test.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/PluginExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
…to WebWorkerExecutionEnvironmentService
shanejonas
force-pushed
the
refactor-plugin-worker-interface
branch
3 times, most recently
from
7517de2
to
6deb30f
Compare
shanejonas
commented
Jun 15, 2021
shanejonas
force-pushed
the
refactor-plugin-worker-interface
branch
from
6deb30f
to
963c8bb
Compare
shanejonas
force-pushed
the
refactor-plugin-worker-interface
branch
from
963c8bb
to
c996ee4
Compare
rekmarks
requested changes
Jun 15, 2021
packages/controllers/src/services/WebWorkerExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/WebWorkerExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/ExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
rekmarks
requested changes
Jun 15, 2021
packages/controllers/src/services/WebWorkerExecutionEnvironmentService.ts
Outdated
Show resolved
Hide resolved
…tService.ts Co-authored-by: Erik Marks <[email protected]>
rekmarks
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes the interface names to not have
workerin them, also changes the interface to them as to not requireworkerId, but use thepluginNameinstead.It establishes a
ExecutionEnvironmentServiceinterface for other Execution Environment Services to follow and used in thePluginControllerto be able to swap out execution environments.It also renames
WorkerControllertoWebWorkerExecutionEnvironmentServicewhich implementsExecutionEnvironmentService.