Refactor CommandEngine to JSON-RPC
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
force-pushed
the
refactor-command-engine-to-jsonrpc
branch
from
037434a
to
94e90fa
Compare
shanejonas
commented
May 14, 2021
rekmarks
requested changes
May 17, 2021
packages/workers/src/PluginWorker.ts
Outdated
|
|
||
| if (!id || typeof id !== 'string') { | ||
| if (!id && typeof id !== 'string' && typeof id !== 'number') { |
There was a problem hiding this comment.
We have complete control over the IDs that come in over this stream, so I think we can mostly keep the original implementation, and just expect either a number or string.
If we're expecting a number, I think we can just do the following, unless we want to e.g. enforce that the numbers are integers.
Suggested change
| if (!id && typeof id !== 'string' && typeof id !== 'number') { | |
| if (typeof id !== 'number') { |
There was a problem hiding this comment.
This check will permit the empty string as an id. Since we're using nanoid now, I think we can revert this and go with the original condition.
rekmarks
changed the title
CommandEngine to JSON-RPCCommandEngine to JSON-RPC
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
shanejonas
commented
May 17, 2021
shanejonas
force-pushed
the
refactor-command-engine-to-jsonrpc
branch
from
57174dc
to
0d356c9
Compare
rekmarks
requested changes
May 17, 2021
packages/workers/src/PluginWorker.ts
Outdated
|
|
||
| if (!id || typeof id !== 'string') { | ||
| if (!id && typeof id !== 'string' && typeof id !== 'number') { |
There was a problem hiding this comment.
This check will permit the empty string as an id. Since we're using nanoid now, I think we can revert this and go with the original condition.
shanejonas
force-pushed
the
refactor-command-engine-to-jsonrpc
branch
from
6e165c3
to
3d554c7
Compare
shanejonas
force-pushed
the
refactor-command-engine-to-jsonrpc
branch
from
3d554c7
to
3e08fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10