Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-712 chainID enforcement issues bug #951

Closed
androolloyd opened this issue Jul 27, 2019 · 0 comments · Fixed by #1021
Closed

EIP-712 chainID enforcement issues bug #951

androolloyd opened this issue Jul 27, 2019 · 0 comments · Fixed by #1021
Assignees

Comments

@androolloyd
Copy link

chainId is an supposed to be optional parameter in the domain specification of eip-712

Currently chainId is not enforced at all by MetaMask mobile

Previously it was a requirement for any signTypedData_v3 request.

Request to have the functionality support enforcing chainId, but ONLY when chainId is present in the domain specification.

@bitpshr bitpshr self-assigned this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants