Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApproveTransactionReview - extract code to render QR details into separate component #6161

Open
jpuri opened this issue Apr 11, 2023 · 2 comments
Open

ApproveTransactionReview - extract code to render QR details into separate component #6161

jpuri opened this issue Apr 11, 2023 · 2 comments
Assignees
@jpuri
Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor

Comments

@jpuri
Copy link
Contributor

jpuri commented Apr 11, 2023

Extract code here to render QR details to separate component:

metamask-mobile/app/components/UI/ApproveTransactionReview/index.js

Line 996 in f5d3bb8

renderQRDetails() {

  • ensure all related functions are also moved
  • ensure test coverage of new component
  • new component can be placed here
@jpuri jpuri added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor labels Apr 11, 2023
@bschorchit bschorchit added this to the ConfirmationsUX_O2KR3 - Refactor [10] critical functions or components in the Mobile confirmations UX code milestone Apr 11, 2023
@jpuri jpuri self-assigned this Apr 19, 2023
@jpuri jpuri mentioned this issue Apr 19, 2023
Merged
@bschorchit bschorchit removed this from the ConfirmationsUX_O2KR3 - Refactor [10] critical functions or components in the Mobile confirmations UX code milestone Apr 20, 2023
@jpuri
Copy link
Contributor Author

jpuri commented Apr 26, 2023

I did a fix for this task in this PR itself: #6213 but it was found to have issues when tested with QR wallet.

I am moving it bask to Ready for Dev to implement it once we have QR hardware wallet in the team for testing.

@bschorchit
Copy link

I moved it to the next sprint as the QR hardware wallet should take 1-2 weeks to arrive

@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
team-confirmations-planning (only for internal use within Confirmations team) type-refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpuri @bschorchit