Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApproveTransactionReview - extract function to render tooltip into a separate component. #6159

Closed
jpuri opened this issue Apr 11, 2023 · 0 comments · Fixed by #6213
Closed

ApproveTransactionReview - extract function to render tooltip into a separate component. #6159

jpuri opened this issue Apr 11, 2023 · 0 comments · Fixed by #6213
Assignees
@jpuri
Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor

Comments

@jpuri
Copy link
Contributor

jpuri commented Apr 11, 2023

Extract the function to render tooltip here into a separate component.

  • the new component can be placed here
  • all tooltip related functions / callbacks should be moved to new component
  • ensure that new component has test coverage
@jpuri jpuri added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor labels Apr 11, 2023
@bschorchit bschorchit added this to the ConfirmationsUX_O2KR3 - Refactor [10] critical functions or components in the Mobile confirmations UX code milestone Apr 11, 2023
@jpuri jpuri self-assigned this Apr 17, 2023
@jpuri jpuri mentioned this issue Apr 19, 2023
Merged
@bschorchit bschorchit removed this from the ConfirmationsUX_O2KR3 - Refactor [10] critical functions or components in the Mobile confirmations UX code milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup approve transaction review MetaMask/metamask-mobile
2 participants
@jpuri @bschorchit